[jira] [Commented] (OFBIZ-11779) Use GroovyBaseScript's makeValue utility methods in each Groovy files

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142810#comment-17142810 ]

Priya Sharma commented on OFBIZ-11779:
--------------------------------------

Hello Pawan,

I have created PRs for this improvement to both framework and plugins component.
Please verify and let me know in case any other changes are needed.

I have tried to verify possible cases, but for the plugins component, I could not find any references to files -
ecommerce/groovyScripts/forum/RespondPermAndPrep.groovy
ecommerce/groovyScripts/forum/EditAddPrep.groovy
ecommerce/groovyScripts/forum/CurrentValPrep.groovy

TIA!

> Use GroovyBaseScript's makeValue utility methods in each Groovy files
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-11779
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11779
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Pawan Verma
>            Assignee: Pawan Verma
>            Priority: Minor
>
> Use GroovyBaseScript's makeValue utility methods instead of using Delegator in each Groovy files
> Currently, we have both patterns in Groovy files, we should replace delegator.makeValue(args) with makeValue(args) for consistency

--
This message was sent by Atlassian Jira
(v8.3.4#803005)