[jira] [Commented] (OFBIZ-11796) Unnecessary iterations for all productFacilities in setLastInventoryCount

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-11796) Unnecessary iterations for all productFacilities in setLastInventoryCount

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127952#comment-17127952 ]

Jacques Le Roux commented on OFBIZ-11796:
-----------------------------------------

Hi Suraj,

Weird that nobody thought about that before. I guess nobody crossed performance issue before, excellent spot Suraj: +1 for commit (only reviewed, but so simple I'm confident)

> Unnecessary iterations for all productFacilities in setLastInventoryCount
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-11796
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11796
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>         Attachments: OFBIZ-11796.patch
>
>
> In the service setLastInventoryCount, which updates lastInventoryCount for product facility records, it works on inventoryItemDetail changes on availableToPromiseDiff.
> In parameter: InventoryItemId
> So it should be updating productFacilities entertaining both productId and facilityId of same inventoryItemId.
> Currently, it it unnecessary updating all the facilities inventory on a single inventory item update.
> It can be major performance factor on a production system working highly on inventory updates.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)