[jira] [Commented] (OFBIZ-11796) Unnecessary iterations for all productFacilities in setLastInventoryCount

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-11796) Unnecessary iterations for all productFacilities in setLastInventoryCount

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128252#comment-17128252 ]

ASF subversion and git services commented on OFBIZ-11796:
---------------------------------------------------------

Commit a6cf5aafda6561f3fabedeea9007718919d15d02 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a6cf5aa ]

Fixed: Unnecessary iterations and setting inventory for all productFacilities in setLastInventoryCount.
(OFBIZ-11796)

Instead of updating all product facilities records on one inventory item change, we should be changing only specific product facility record for that the inventory item belongs to. Thanks Jacques, Pierre, Pawan and Arun for the review.


> Unnecessary iterations for all productFacilities in setLastInventoryCount
> -------------------------------------------------------------------------
>
>                 Key: OFBIZ-11796
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11796
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>         Attachments: OFBIZ-11796.patch
>
>
> In the service setLastInventoryCount, which updates lastInventoryCount for product facility records, it works on inventoryItemDetail changes on availableToPromiseDiff.
> In parameter: InventoryItemId
> So it should be updating productFacilities entertaining both productId and facilityId of same inventoryItemId.
> Currently, it it unnecessary updating all the facilities inventory on a single inventory item update.
> It can be major performance factor on a production system working highly on inventory updates.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)