[jira] [Commented] (OFBIZ-11804) Change decimals, rounding, zero static variables names as per best practices

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134697#comment-17134697 ]

ASF subversion and git services commented on OFBIZ-11804:
---------------------------------------------------------

Commit c03e27d73e860ccb3a9bd8950f3771d68e8dd0dc in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c03e27d ]

Improved: Changed decimals, rounding, zero static variables names as per best practices in order component. (#196)

(OFBIZ-11804)
Also make them private data members of the class.

> Change decimals, rounding, zero static variables names as per best practices
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-11804
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11804
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>
> As we have done it for modules, resources, it is better to get this done for all similar variables as well.
> decimals -> DECIMALS
> rounding -> ROUNDING
> zero -> ZERO
> Also, we should make these variables as private instead of public.

--
This message was sent by Atlassian Jira
(v8.3.4#803005)