[jira] [Commented] (OFBIZ-11817) a handful of bug fixes

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-11817) a handful of bug fixes

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-11817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130796#comment-17130796 ]

Pierre Smits commented on OFBIZ-11817:
--------------------------------------

Hi [~alexbodn],

Thank you for your contribution. 

A few observations....
 # it seems to me your patch contains both bug fixes for existing components and introduces a new plugin called 'csp'. The introduction of the plugin should not happen under this ticket;
 # your patch contains fixes for both the base and additional plugins; Please consider to split that up, as plugins are maintained in a separate repository.
 # Please consider to introduce your patch(es) as Pull Requests to the appropriate repository (available via GitHub: [https://github.com/apache/ofbiz-framework] and [https://github/apache/ofbiz-plugins] ) as it will get some automated vetting done when the Pull Request is received there.

> a handful of bug fixes
> ----------------------
>
>                 Key: OFBIZ-11817
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11817
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS, ALL PLUGINS
>    Affects Versions: 17.12.03, Trunk
>         Environment: [^apache-ofbiz-17.12.03.patch]
>            Reporter: Alex Bodnaru
>            Priority: Minor
>             Fix For: Release Branch 17.12, Trunk
>
>         Attachments: apache-ofbiz-17.12.03.patch
>
>
> hello friends,
> i'm an experienced software developer wishing to learn more about the supply chain and logistics.
> to do my enhancements, i need to reduce the errors and warnings in the log, hence i offer you with a few fixes:
> added namespace to a few xmls.
> improved the support for csp, to even log browser reports by a modest plugin i've made.
> made a few minor bug fixes.
> adjusted a few map files for minified css and js files.
> please take a look and enjoy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)