[
https://issues.apache.org/jira/browse/OFBIZ-11822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136584#comment-17136584 ]
ASF subversion and git services commented on OFBIZ-11822:
---------------------------------------------------------
Commit 488b9b6b9a914777f4e56bbac611c72159564b2b in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux
[
https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=488b9b6 ]
Improved: Checks if the value passed to checkStringForHtmlSafe is not null (OFBIZ-11822)
This was reported by SpotBugs in Eclipse to prevent a possible NPE.
It seems to me that it's more complex than that because of the
PolicyFactory::sanitize methods signatures where @Nullable annotation is
used. So the SpotBugs warning remains, anyway can't hurt.
BTW found 92 issues reported by SpotBugs in Eclipse, among them 33 are "scary"
I had to add 1 to tasks.checkstyleMain.maxErrors because of
https://github.com/apache/ofbiz-framework/pull/203 that I pulled after the push
was rejected by the pre-push local Git hook
> Double encoded urls are not being decoded
> -----------------------------------------
>
> Key: OFBIZ-11822
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11822> Project: OFBiz
> Issue Type: Bug
> Components: base
> Affects Versions: 17.12.03, Trunk
> Reporter: Alex Bodnaru
> Assignee: Jacques Le Roux
> Priority: Trivial
> Fix For: 18.12.01, 17.12.04
>
> Attachments: apache-ofbiz-17.12.03-fr2.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> a small miss-out error, the urlcodec decode output is not being used
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
