[
https://issues.apache.org/jira/browse/OFBIZ-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136664#comment-17136664 ]
Suraj Khurana commented on OFBIZ-11823:
---------------------------------------
Hello [~pawan] ,
This seems moreover a good java code improvement over performance.
Also, I would like to add we should be handling PICKITEM_CANCELLED status as well, not sure why it wasn't handled yet.
Consider a case of partial successful picking for a bin/order, if one out of two picklist bin items is cancelled and another is completed, than also this method should be returning true. WDYT?
> Refactor PickListServices#isBinComplete method to remove unnecessary iterations
> -------------------------------------------------------------------------------
>
> Key: OFBIZ-11823
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11823> Project: OFBiz
> Issue Type: Improvement
> Components: product/facility
> Affects Versions: Trunk
> Reporter: Pawan Verma
> Assignee: Pawan Verma
> Priority: Minor
> Attachments: OFBIZ-11823.patch
>
>
> PickListServices#isBinComplete() is used to check if picklistBin is complete.
> This method reduces system performance when a picklistBin contains heavy no of items in it, this method iterator all the items to check the status of the item to validate if the bin is complete or not.
> Instead of iteration, we can add itemStatusId != PICKITEM_COMPLETED condition while fetching records from the entity using queryCount() method and if we found count then picklistBin is not complete.
> It can be a major performance factor on a production system working on heavy orders.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
