[
https://issues.apache.org/jira/browse/OFBIZ-11846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147604#comment-17147604 ]
Suraj Khurana commented on OFBIZ-11846:
---------------------------------------
Hello [~pawan],
{code:java}
if (dynamicViewEntity == null && this.havingEntityCondition == null) {
- result = delegator.findList(entityName, makeWhereCondition(useCache), fieldsToSelect, orderBy, findOptions, useCache);
+ result = delegator.findList(entityName, makeWhereCondition(useCache), havingEntityCondition, fieldsToSelect, orderBy, findOptions, useCache);
{code}
Here in this area, earlier there was a condition 'this.havingEntityCondition == null'.
I think that should be changed as per this implementation to work properly. Am I missing something?
Its just a cursory code-review, I haven't tried it yet.
> Introduce support for having condition in EntityQuery#queryList method
> ----------------------------------------------------------------------
>
> Key: OFBIZ-11846
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11846> Project: OFBiz
> Issue Type: Improvement
> Components: framework/entity
> Affects Versions: Trunk
> Reporter: Pawan Verma
> Assignee: Pawan Verma
> Priority: Major
> Attachments: OFBIZ-11846.patch
>
>
> While reading code with [~nitish.mishra], we found that EntityQuery.queryList() method does not have support for having conditions while the queryIterator() method has.
> So, It would be good to have the support in EntityQuery.queryList() as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
