[
https://issues.apache.org/jira/browse/OFBIZ-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158231#comment-17158231 ]
Jacques Le Roux commented on OFBIZ-11881:
-----------------------------------------
So you did not read (or get, hard to swallow I agree) the contributors best practices yet :p.
So here is another point (after using trunk HEAD when creating your patches, reminder): please use names for your patches where the Jira issue number is. It's easier to follow for committers when working on several patches at the "same time", TIA. And create the patches from the root of the repo (main dir for framework and application, plugins dir for, er, plugins)
This said your patch (only the d.png related hunks) does not apply despite not returning error when using git apply from framework dir. Please create it again (only the d.png related hunks) following our best practices (ie with a number, from main dir), TIA.
> wrong image name in css. missing map file
> -----------------------------------------
>
> Key: OFBIZ-11881
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11881> Project: OFBiz
> Issue Type: Bug
> Components: themes
> Affects Versions: Release Branch 17.12, Trunk
> Reporter: Alex Bodnaru
> Assignee: Jacques Le Roux
> Priority: Trivial
> Labels: patch
> Attachments: jquery-plugins.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> patch conclusive
> the missing map file may be downloaded from the plugin site.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
