[jira] [Commented] (OFBIZ-11882) Rename a few map files

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-11882) Rename a few map files

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164458#comment-17164458 ]

Jacques Le Roux commented on OFBIZ-11882:
-----------------------------------------

I had a look at the tools for creating maps and minifying. It's all about js and I don't like it much. I want a clean easy solution: a Gradle task :)

Despite being kinda abandoned https://github.com/eriwen/gradle-js-plugin is still the best solution for us. Trunk currently uses Gradle 6.3. So we need to find a fork which supports that or need to create our own fork. https://github.com/twwwt/gradle-js-plugin which claims to handle 6.1.1 could be a good start if we don't find better. I came to this conclusion after my last comment at OFBIZ-11882:
bq. Sure we should have source maps for CSS files too, even in production: https://css-tricks.com/should-i-use-source-maps-in-production/

I wrote but did not publish this few days ago. In the meantime I have created my own plugin based on eriwen's and modified following twwwt's. I'll publish it soon, will close here and will see what I can get from it. I have notably found that I can't view jQuery source. I never missed that, but if the plugin works as expected we would have all the necessary maps.

> Rename a few map files
> ----------------------
>
>                 Key: OFBIZ-11882
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11882
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: Release Branch 17.12, Trunk
>            Reporter: Alex Bodnaru
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: 18.12.01, 17.12.05
>
>         Attachments: ecommerce-js.patch, ecommerce-js2.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> tells a few files to be renamed, to suppress warnings in the browser console.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)