[
https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159260#comment-17159260 ]
Aditya Sharma commented on OFBIZ-11882:
---------------------------------------
Hi Jacques,
For most of the libraries we have added/upgraded we simply download the official packages and added/replaced. We tried to ensure that we do least or no changes to original packages. Also, we haven't minified any of the files, most of the minified files are from the official release.
I think for jQuery I have downloaded the files through the links from the official blog and simply replaced them.
[
https://blog.jquery.com/2020/05/04/jquery-3-5-1-released-fixing-a-regression/]
But, it seems the path through [download|
https://jquery.com/download/] page or [GitHub|
https://github.com/jquery/jquery/releases/tag/3.5.1] would have been a much better option.
I noticed that the minified files for jQuery don't come with a sourceMappingUrl as a comment in them
[
https://github.com/jquery/jquery/issues/4166]
[|
https://blog.jquery.com/2014/01/24/jquery-1-11-and-2-1-released/]
|We've removed the comment on purpose, see [
https://blog.jquery.com/2014/01/24/jquery-1-11-and-2-1-released/]. There are many problems with including the comment, one of them being that different CDNs use different file names so the comment would have to be different for different CDNs and that kills security features like Subresource Integrity.
You can still attach the map manually via DevTools, at least Chrome supports that.|
We will have to add the sourceMappingUrl to the minified file manually and add the source map file.
> rename a few map files
> ----------------------
>
> Key: OFBIZ-11882
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11882> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
> Affects Versions: Release Branch 17.12, Trunk
> Reporter: Alex Bodnaru
> Assignee: Jacques Le Roux
> Priority: Trivial
> Attachments: ecommerce-js.patch, ecommerce-js2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> tells a few files to be renamed, to suppress warnings in the browser console.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
