[jira] [Commented] (OFBIZ-11886) Allow single line statements in checkstyle

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-11886) Allow single line statements in checkstyle

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161799#comment-17161799 ]

ASF subversion and git services commented on OFBIZ-11886:
---------------------------------------------------------

Commit afa98bb8a6665484dd4f20815e20cb1b12b6a9d7 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=afa98bb ]

Improved: Updated checkstyle.xml with allowSingleLineStatement as true, this brings down checkstyle maxErrors to 20037.(-625).
(OFBIZ-11886)
Thanks Jacques for your suggestions and comments.


> Allow single line statements in checkstyle
> ------------------------------------------
>
>                 Key: OFBIZ-11886
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11886
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>         Attachments: OFBIZ-11886-format-LoginServices-checkNewPassword.patch, OFBIZ-11886-plugins.patch, OFBIZ-11886.patch, OFBIZ-11886.patch
>
>
> We need to add this module in checkstyle.xml
> <module name="NeedBraces">
>     <property name="allowSingleLineStatement" value="true"/>
>  </module>
> After this, single line statements like:
> if (Debug.verboseOn()) Debug.logVerbose(...)
> Will be considered safe.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)