[jira] [Commented] (OFBIZ-11899) Can't enter decimals when ordering on ecommerce

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-11899) Can't enter decimals when ordering on ecommerce

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-11899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173663#comment-17173663 ]

ASF subversion and git services commented on OFBIZ-11899:
---------------------------------------------------------

Commit 5366f7d85e126f065f6272fe57f4924e2f921011 in ofbiz-plugins's branch refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=5366f7d ]

Improved: Can't enter decimals when ordering on ecommerce (OFBIZ-11899)

In stable demo, and R18 locally, you can order a half pizza, that's no longer
possible in trunk demo.

Moreover you can't use the Add button in trunk, And if you use the Config button
then it orders. There must be a mix between the 2 buttons, maybe the reason
why we can't no longer enter decimals in trunk...

Suraj: Added a patch with some refactoring of js code and used form attribute to
get quantity value for addform.
This might work with the provided patch but I think a better solution could be
through markup. Also, due to some time constraints, I was not able to dig deep
into how it is working in another branch.

It's a workaround that we can use to continue over OFBIZ-11916.
But I don't like that we have both add_amount and quantity fields out of the
addform form. Actually as I explained at https://markmail.org/message/lnz57yzj3uywcr2y
I don't even understand how this is possible since the FTL source sounds correct...

Thanks: Suraj for the temporary workaround


> Can't enter decimals when ordering on ecommerce
> -----------------------------------------------
>
>                 Key: OFBIZ-11899
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11899
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Priority: Major
>         Attachments: OFBIZ-11899.patch
>
>
> In stable demo, and R18 locally, you can order a half pizza, that's no longer possible in trunk demo.
> Moreover you can't use the Add button in trunk, And if you use the Config button then it orders. There must be a mix between the 2 buttons, maybe the reason why we can't no longer enter decimals in trunk...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)