[
https://issues.apache.org/jira/browse/OFBIZ-11900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184155#comment-17184155 ]
Jacques Le Roux commented on OFBIZ-11900:
-----------------------------------------
Hi Daniel,
I cursorily reviewed PR232, I see you made use of Lombok. After the conversation at
https://markmail.org/message/c3czqxkanhcm5eo4 its usage could be considered a lazy consensus. But I'm not sure it's the case, notably with [~grv]'s remark. So I'd merge it before we are sure it's OK with Lombok usage in OFBiz code.
> Extract FTL macro call generation from MacroFormRenderer
> --------------------------------------------------------
>
> Key: OFBIZ-11900
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11900> Project: OFBiz
> Issue Type: Sub-task
> Components: framework/widget
> Affects Versions: Trunk
> Reporter: Daniel Watford
> Assignee: Daniel Watford
> Priority: Minor
>
> As part of refactoring MacroFormRenderer (OFBIZ-11456), extract code responsible for building the FTL macro calls for form elements into a supporting class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
