[jira] [Commented] (OFBIZ-11906) product summary looks bad in the promotion products list

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164326#comment-17164326 ]

Aditya Sharma commented on OFBIZ-11906:
---------------------------------------

Hi Alex,
Instead of adding a class to make the width 100%, I would recommend that we could identify the promotion products card with some class and apply CSS to products-card. Check OFBIZ-11906.patch, it will reduce the additional code written just to add class.
WDYT?

 

> product summary looks bad in the promotion products list
> --------------------------------------------------------
>
>                 Key: OFBIZ-11906
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11906
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: Release Branch 17.12, Trunk
>            Reporter: Alex Bodnaru
>            Assignee: Aditya Sharma
>            Priority: Major
>         Attachments: OFBIZ-11906.patch, ProductSummary.ftl.diff, PromotionProducts.ftl.diff, Screen Shot change.png, Screen Shot original.png, custom.css.diff
>
>
> the product summary in the row is too slim, leaving 75% of the place unused.
> solution: adding a class to the product summary card by parameter.
> the class i'm adding here is forcing a width of 100% in custom.css.
> of course, this class may be used in other scenarios too, and multiple classes may be separed by space.

--
This message was sent by Atlassian Jira
(v8.3.4#803005)