[
https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182457#comment-17182457 ]
Ankush Upadhyay commented on OFBIZ-11928:
-----------------------------------------
[~pradeep.choudhary1994], [~surajk],
In order creation workflow, it calls makeOrderItems() that internally call explodeItems() so the explodeItems() iterate all items and start to explode them one by one using method ShoppingCartItem.explodeItem() so to explode each quantity, it uses setQuantity() method of ShoppingCartItem that clear cart's ship info object using method
cart.clearItemShipInfo(this); So from here the tax details are getting removed.
I think the tax should also needs to explode with items. To do so there can be possible solutions like
# Can calculate and add tax again for exploded items using method CheckoutHelper.calcAndAddTax().
# Before calling explodeItem(), somehow get the tax info from ship info object, prorate tax for exploded items.
I tried to verify #1 solution and it worked as expected, it exploded item tax as well. I would try to verify all order level data.
> Explode items not handling tax and adjustments properly
> -------------------------------------------------------
>
> Key: OFBIZ-11928
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11928> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
> Reporter: Suraj Khurana
> Assignee: Pradeep Choudhary
> Priority: Major
> Attachments: image-2020-08-22-14-54-06-042.png
>
>
> Steps to re-generate:
> 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo
> 2) Now change explode item to Y
> 3) Again create same order with same products and same quantity
> 4) Notice difference in item subtotal and grand total
> I see two issues here:
> - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is correct when explode is set to N (default order)
> Code reference: It should be handled inside ShoppingCartItem.java#explodeItem
> - Total sales tax is different in both orders:
> 10.72 and -0.03 which can be checked if this is any configuration issue, or taxes are not being handled while exploding items.
> Demo orders on trunk (will not last for long):
> explode: N
> [
https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001> ]explode: Y
> [
https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10000]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
