[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193581#comment-17193581 ]

Jacques Le Roux commented on OFBIZ-11955:
-----------------------------------------

Hi Alex,

Here you go:

$  patch -p1 -R < variantinfojs-undo.patch
patching file applications/order/groovyScripts/entry/catalog/InlineProductDetail.groovy
Unreversed patch detected!  Ignore -R? [n]
Apply anyway? [n] y
Hunk #1 succeeded at 105 with fuzz 2 (offset 3 lines).
Hunk #2 FAILED at 287.
Hunk #3 FAILED at 301.
2 out of 3 hunks FAILED -- saving rejects to file applications/order/groovyScripts/entry/catalog/InlineProductDetail.groovy.rej
patching file applications/order/groovyScripts/entry/catalog/ProductDetail.groovy
Unreversed patch detected!  Ignore -R? [n]
Apply anyway? [n] Y
Skipping patch.
5 out of 5 hunks ignored -- saving rejects to file applications/order/groovyScripts/entry/catalog/ProductDetail.groovy.rej
patching file applications/order/groovyScripts/entry/catalog/ProductSummary.groovy
Unreversed patch detected!  Ignore -R? [n]
Apply anyway? [n] Y
Skipping patch.
3 out of 3 hunks ignored -- saving rejects to file applications/order/groovyScripts/entry/catalog/ProductSummary.groovy.rej
patching file applications/order/template/entry/catalog/ProductDetail.ftl
Unreversed patch detected!  Ignore -R? [n]
Apply anyway? [n] y
Hunk #1 FAILED at 279.
Hunk #2 FAILED at 479.
Hunk #3 FAILED at 496.
3 out of 3 hunks FAILED -- saving rejects to file applications/order/template/entry/catalog/ProductDetail.ftl.rej
patching file applications/order/template/entry/catalog/ProductSummary.ftl
Unreversed patch detected!  Ignore -R? [n]
Apply anyway? [n] y
Hunk #1 FAILED at 49.
Hunk #2 FAILED at 97.
Hunk #3 succeeded at 104 with fuzz 2 (offset -1 lines).
Hunk #4 FAILED at 137.
3 out of 4 hunks FAILED -- saving rejects to file applications/order/template/entry/catalog/ProductSummary.ftl.rej
patching file applications/order/template/entry/catalog/ProductUomDropDownOnly.ftl
Unreversed patch detected!  Ignore -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file applications/order/template/entry/catalog/ProductUomDropDownOnly.ftl.rej
The next patch, when reversed, would create the file applications/order/template/entry/catalog/ProductVariantJS.ftl,
which already exists!  Ignore -R? [n]
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored
patching file applications/order/widget/ordermgr/OrderEntryCatalogScreens.xml
Hunk #1 succeeded at 74 (offset 8 lines).

 [^ProductUomDropDownOnly.ftl.rej]  [^ProductSummary.ftl.rej]  [^ProductDetail.ftl.rej]  [^ProductSummary.groovy.rej]  [^ProductDetail.groovy.rej]  [^InlineProductDetail.groovy.rej]

> display/selection of unit of measure is broken
> ----------------------------------------------
>
>                 Key: OFBIZ-11955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11955
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce, order
>    Affects Versions: Release Branch 17.12, Trunk
>            Reporter: Alex Bodnaru
>            Priority: Major
>         Attachments: Image 002.png, Image 002.png, Image damned.png, Image1.png, InlineProductDetail.groovy.rej, ProductDetail.ftl.rej, ProductDetail.groovy.rej, ProductSummary.ftl.rej, ProductSummary.groovy.rej, ProductUomDropDownOnly.ftl.rej, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml, variantinfojs-final.patch, variantinfojs-undo.patch
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple forms, one for each product: whether detailed or in summary. thus, they should be marked by names and classes, not by ids, that are unique in the entire document.
> the bug did not manifest in demo data, since only one product has alternative packaging.
> i did duplicate wg-1111* products and arranged their relations. is, btw, a way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.

--
This message was sent by Atlassian Jira
(v8.3.4#803005)