[
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199261#comment-17199261 ]
Jacques Le Roux commented on OFBIZ-11955:
-----------------------------------------
Hi Alex,
TL;DR
{noformat}
You need to be more specific in what your changes implie in term of changed features. For instance I read:
bq. // Format to apply the currency code to the variant price in the javascript
Why did you move that block and what should I check?
Also why did you comment out several small parts?
Or about <<function displayProductVirtualId(variantId, virtualProductId, pForm) {>>?
In other words don't expect me to be the one which reviews and tests your changes w/o having an idea about what I'm doing :)
You have already made a lot of changes in these Jira (OFBIZ-11993 and here) and, w/ the time passing, it begins to be convoluted...
{noformat}
This said , I expect it's only about the titles (ie "display/selection of unit of measure is broken/plugins") and I checked only that.
It works well in both ordermgr and ecommerce.
One question: the changes in ecommerce and ordermgr are independent, right?
> display/selection of unit of measure is broken
> ----------------------------------------------
>
> Key: OFBIZ-11955
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11955> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, order
> Affects Versions: Release Branch 17.12, Trunk
> Reporter: Alex Bodnaru
> Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-clean1.patch, variantinfojs-data.xml, variantinfojs-final.patch, variantinfojs-undo.patch
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple forms, one for each product: whether detailed or in summary. thus, they should be marked by names and classes, not by ids, that are unique in the entire document.
> the bug did not manifest in demo data, since only one product has alternative packaging.
> i did duplicate wg-1111* products and arranged their relations. is, btw, a way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
