[
https://issues.apache.org/jira/browse/OFBIZ-11957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181041#comment-17181041 ]
Dennis Balkir commented on OFBIZ-11957:
---------------------------------------
Hi Jacques,
actually PR227 includes all the changes that I made in the previous PR and the missing line, as I mentioned before.
I tested it on the branch that I provided for the pull request by adding a submit field with an id to the first form in {{PartyForms.xml}} and it worked for me (means the id got rendered in the HTML code).
Wouldn't it be better to make a new issue for other kinds of fields, since I just made this issue for form fields and it could be kind of confusing if we start to add other changes to it now.
bq. Also trivial just for syntax consistency, you should better use id="" in renderSubmitField "signature", like in for
bq.
bq. title="" name="" event="" confirmation="" containerId="" tabindex=""
I did not do it like this, because as you can see in the macro, most of the field do not have this kind of declaration and since ID is not really a necessary field for HTML-elements and HAS to be unique for it to work, it would be a really bad idea to give it a default value.
{noformat}
<#macro renderSubmitField buttonType className alert formName action imgSrc ajaxUrl id title="" name="" event="" confirmation="" containerId="" tabindex="">
{noformat}
> Form-Fields of certain types won't render IDs
> ---------------------------------------------
>
> Key: OFBIZ-11957
> URL:
https://issues.apache.org/jira/browse/OFBIZ-11957> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Trunk
> Reporter: Dennis Balkir
> Assignee: Dennis Balkir
> Priority: Minor
>
> While implementing some OFBiz-Forms, I noticed, that certain types of form-fields will not render the set ID.
> Field-Types that won't work for sure are {{submit}} and {{hyperlink}} where the set name for the parameter {{id-name}} simply will not be rendered in the HTML-Code that is generetad by OFBiz.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
