[jira] [Commented] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181713#comment-17181713 ]

Jacques Le Roux commented on OFBIZ-11963:
-----------------------------------------

Hi Suraj,

Wait I completly missed to add a word in my comment above
bq. This goes against what is currently doing

I missed a link to https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions, exactly to
bq. The line length of 150 is an exception to the Sun standard. Here is an example of a Java formatter for Eclipse:
https://gitbox.apache.org/repos/asf?p=ofbiz-tools.git;a=blob_plain;f=wiki-files/OFBizJavaFormatter.xml

Know I understand why it was confusing you (copied from our - slighely edited-  Slack exchange):

{quote}
Suraj  14:11
Hello Jacques,
I am bit confused by OFBIZ-11963

Jacques Le Roux  14:11
Hi Suraj

Suraj  14:11
The transformation example works fine at my end
Just an additional line needs to be removed
Like this
 !Screenshot 2020-08-20 at 5.42.17 PM.png!

Jacques Le Roux  14:12
Yes, but the 2nd is generated by the transformer (in Eclipse) (edited)
We need to be consistent, else it will be a not ending nightmare
I'm not supporting one or the other, just consistency is needed

Suraj  14:14
Yes for sure.

Jacques Le Roux  14:14
Yes, but My 2nd example is generated by the transformer (in Eclipse)

Suraj  14:15
The example you added has line breaks as well, which should be avoided I guess.

Jacques Le Roux  14:16
That's a choice. My 2nd examle is based on Sun convention. We can override that, but we need to be all conscious and OK
That's all I want to say, did you get it? :slightly_smiling_face:
BTW I find the additional line OK :smile:
Maybe not the additional line+S+

Suraj  14:18
Yes, got it. I noticed many different forms of comments over services instead of Javadoc

Jacques Le Roux  14:18
Yes we need consistency
This said you are doing an excellent job with formatting, thanks!
OK, I must go

Suraj  14:20
Sure, thanks Jacques
{quote}

That's why I created https://markmail.org/message/fdlikan2u6ygxhvg. We need to get a (possibly lazy) consensus to modify the reference that is
https://gitbox.apache.org/repos/asf?p=ofbiz-tools.git;a=blob_plain;f=wiki-files/OFBizJavaFormatter.xml which is based on Sun conventions. It would be OK with me BTW :)

> Checkstyle: Variable must be private and have accessor methods
> --------------------------------------------------------------
>
>                 Key: OFBIZ-11963
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11963
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>         Attachments: OFBIZ-11963-plugins.patch, OFBIZ-11963.patch, Screenshot 2020-08-20 at 5.42.17 PM.png
>
>

--
This message was sent by Atlassian Jira
(v8.3.4#803005)