[jira] [Commented] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192880#comment-17192880 ]

ASF subversion and git services commented on OFBIZ-11963:
---------------------------------------------------------

Commit 5d8541ebf85af42ddff6ffce6ae9c1e269fad7ce in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5d8541e ]

Fixed: Checkstyle, variable must be private and have accessor methods (OFBIZ-11963)

Removes RESOURCE, not used anywhere
Replaces keyseparator by KEY_SEPARATOR in Groovy files that use it

We need to be careful about Groovy files that use variables. At least Eclipse
Grooby plugin is not able to check that in an easy way (ill-names vars are
though underlined)


> Checkstyle: Variable must be private and have accessor methods
> --------------------------------------------------------------
>
>                 Key: OFBIZ-11963
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11963
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>         Attachments: OFBIZ-11963-2.patch, OFBIZ-11963-plugins-2.patch, OFBIZ-11963-plugins.patch, OFBIZ-11963.patch, Screenshot 2020-08-20 at 5.42.17 PM.png
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)