[jira] [Commented] (OFBIZ-12057) Prevent arbitary file write using webtools/control/EntitySQLProcessor.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-12057) Prevent arbitary file write using webtools/control/EntitySQLProcessor.

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-12057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17232744#comment-17232744 ]

ASF subversion and git services commented on OFBIZ-12057:
---------------------------------------------------------

Commit 792f45773fd062fe1f57f5b1af9da9e65637ec54 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=792f457 ]

Fixed: Prevent arbitary file write using webtools/control/EntitySQLProcessor. (OFBIZ-12057)

Shuibo Ye <[hidden email]> reported a possible arbitary file write using
webtools/control/EntitySQLProcessor.

    In the "SQL Command" part, I create a table and insert some strings and
    export the table to a file one sentence at a time.
    PoC: CREATE TABLE "test" (string VARCHAR(80))
    INSERT INTO "test" (string) VALUES ('<%= system.getProperty("user.dir") %>')
    call SYSCS_UTIL.SYSCS_EXPORT_TABLE(null,'test','.\framework\webtools\webapp\webtools\default.jsp',null,'*',null)

    After executing the three sentences,I successfully write the file and its url
    is https://localhost:8443/webtools/default.jsp.

I fixed it preventing execution on SYSCS_UTIL.SYSCS_EXPORT_TABLE and JSP, more
could be added if necessary


> Prevent arbitary file write using webtools/control/EntitySQLProcessor.
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-12057
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12057
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework/webtools
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Major
>
> Shuibo Ye <[hidden email]> reported a possible arbitary file write using webtools/control/EntitySQLProcessor.
> {quote}
> In the "SQL Command" part, I create a table and insert some strings and export the table to a file *one sentence at a time*.
> PoC:  CREATE TABLE "test" (string VARCHAR(80))
>         INSERT INTO "test" (string) VALUES ('<%= system.getProperty("user.dir") %>')
>         call SYSCS_UTIL.SYSCS_EXPORT_TABLE(null,'test','.\framework\webtools\webapp\webtools\default.jsp',null,'*',null)
> After executing the three sentences,I successfully write the file and its url is https://localhost:8443/webtools/default.jsp.
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)