[jira] [Commented] (OFBIZ-12061) Comment out HideUtilityClassConstructor in checkstyle.xml

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-12061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234772#comment-17234772 ]

ASF subversion and git services commented on OFBIZ-12061:
---------------------------------------------------------

Commit 2480c52c6ac2b0498bc7a958c2a8dcbd4c8afbd9 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2480c52 ]

Improved: Comment out HideUtilityClassConstructor in checkstyle.xml (OFBIZ-12061)

Currently Checkstyle returns 222 occurrences of the message
"Utility classes should not have a public or default constructor."

This is due to https://checkstyle.sourceforge.io/config_design.html#HideUtilityClassConstructor
I don't think we need to follow the "prevents calls from subclass" suggestion there.

I rather suggest to comment out the related class in checkstyle.xml:

    ie <!-- <module name="HideUtilityClassConstructor"/> -->

Then should remain only 280 errors and hopefully most will be easy to fix.
At least they will be easier to spot...

Note: I'm working on something else, so I will change
tasks.checkstyleMain.maxErrors from 502 to 280 later...

Thanks: Suraj and Aditya for confirmation

> Comment out HideUtilityClassConstructor in checkstyle.xml
> ---------------------------------------------------------
>
>                 Key: OFBIZ-12061
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12061
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Jacques Le Roux
>            Priority: Major
>
> Currently Checkstyle returns 222 occurrences of the message "Utility classes should not have a public or default constructor."
> This is due to https://checkstyle.sourceforge.io/config_design.html#HideUtilityClassConstructor
> I don't think we need to follow the "prevents calls from subclass" suggestion  there.
> I rather suggest to comment out the related class in checkstyle.xml:
> bq. ie <!-- <module name="HideUtilityClassConstructor"/> -->
> Then should remain only 280 errors and hopefully most will be easy to fix. At least they will be easier to spot...

--
This message was sent by Atlassian Jira
(v8.3.4#803005)