[jira] [Commented] (OFBIZ-12103) Unable to cancel item from ecommerce

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-12103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17292158#comment-17292158 ]

Jacques Le Roux commented on OFBIZ-12103:
-----------------------------------------

Actually it indeed works, but this error (complete here) in log


{noformat}
2021-02-27 16:03:09,097 |Thread-42            |ServiceDispatcher             |T| [[ASync service finished...- total:0.153,since last(ASync service sta...):0.153]] - 'ecommerce / sendOrderChangeNotification'
2021-02-27 16:03:09,111 |Thread-40            |CommonPermissionServices      |I| Checking for alternate permission ORDERMGR_ROLE_UPDATE
2021-02-27 16:03:09,112 |Thread-40            |ServiceDispatcher             |T| Sync service [ecommerce/genericBasePermissionCheck] finished in [139] milliseconds
2021-02-27 16:03:09,112 |Thread-40            |ServiceDispatcher             |T| Sync service [ecommerce/orderAdjustmentPermissionCheck] finished in [166] milliseconds
2021-02-27 16:03:09,112 |Thread-40            |ServiceUtil                   |E| {errorMessage=Security Error To Run Auto Create Order Adjustments, responseMessage=error}
2021-02-27 16:03:09,113 |Thread-40            |ServiceDispatcher             |T| [[Sync service failed...- total:0.0,since last(Begin):0.0]] - 'ecommerce / recreateOrderAdjustments'
2021-02-27 16:03:09,113 |Thread-40            |TransactionUtil               |W| Calling transaction setRollbackOnly; this stack trace shows where this is happening:
java.lang.Exception: Service [recreateOrderAdjustments] threw an unexpected exception/error
        at org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:372) [main/:?]
        at org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:306) [main/:?]
        at org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:551) [main/:?]
        at org.apache.ofbiz.service.ServiceDispatcher.runSyncIgnore(ServiceDispatcher.java:254) [main/:?]
        at org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSyncIgnore(GenericDispatcherFactory.java:122) [main/:?]
        at org.apache.ofbiz.service.ServiceSynchronization$ServiceExecution$1.run(ServiceSynchronization.java:162) [main/:?]
2021-02-27 16:03:09,113 |Thread-40            |ServiceSynchronization        |E| Problem calling [Commit] service : recreateOrderAdjustments / {orderItemSeqId=00001, userLogin=[GenericEntity:UserLogin][createdStamp,2021-02-27 14:12:55.42
2(java.sql.Timestamp)][createdTxStamp,2021-02-27 14:12:54.681(java.sql.Timestamp)][currentPassword,$SHA$x7dRKpYj$RG1qqHfpxopYlLQRIPtUZZDAHj4(java.lang.String)][disabledBy,null()][disabledDateTime,null()][enabled,Y(java.lang.String)][exte
rnalAuthId,null()][hasLoggedOut,N(java.lang.String)][isSystem,null()][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,null()][lastUpdatedStamp,2021-02-27 15:04:18.227(java.sql.Timestamp)][lastUpdatedTxStamp,2021-02-27 15:04:18.22
6(java.sql.Timestamp)][partyId,10010(java.lang.String)][passwordHint,5x5(java.lang.String)][requirePasswordChange,null()][successiveFailedLogins,null()][userLdapDn,null()][userLoginId,[hidden email](java.lang.String)], visualTheme=visual-theme-
id:RAINBOWSTONE_SAPHIR, display-name: Rainbow Stone - Sapphire, description: ${util:label('CommonEntityLabels', 'VisualTheme.description.RAINBOWSTONE_SAPHIR', locale)}, screenshots: [/rainbowstone/images/themeSaphir.png], itemReasonMap={
00002=, 00003=, 00001=OICR_CHANGE_MIND}, orderId=WSCO10050, itemCommentMap={00002=, 00003=, 00001=}, timeZone=sun.util.calendar.ZoneInfo[id="Europe/Paris",offset=3600000,dstSavings=3600000,useDaylight=true,transitions=184,lastRule=java.u
til.SimpleTimeZone[id=Europe/Paris,offset=3600000,dstSavings=3600000,useDaylight=true,startYear=0,startMode=2,startMonth=2,startDay=-1,startDayOfWeek=1,startTime=3600000,startTimeMode=2,endMode=2,endMonth=9,endDay=-1,endDayOfWeek=1,endTi
me=3600000,endTimeMode=2]], itemQtyMap={}, locale=en_US, responseMessage=success}
org.apache.ofbiz.service.ServiceAuthException: You haven't the permission for the service recreateOrderAdjustments, reason : Security Error To Run Auto Create Order Adjustments
        at org.apache.ofbiz.service.ServiceDispatcher.checkAuth(ServiceDispatcher.java:989) ~[main/:?]
        at org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:375) ~[main/:?]
        at org.apache.ofbiz.service.ServiceDispatcher.runSyncIgnore(ServiceDispatcher.java:254) ~[main/:?]
        at org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSyncIgnore(GenericDispatcherFactory.java:122) ~[main/:?]
        at org.apache.ofbiz.service.ServiceSynchronization$ServiceExecution$1.run(ServiceSynchronization.java:162) [main/:?]
2021-02-27 16:03:09,113 |Thread-40            |TransactionUtil               |I| Transaction rolled back
{noformat}

I think we can already commit and backport the fix and create a new issue for this error, what do you think?

> Unable to cancel item from ecommerce
> ------------------------------------
>
>                 Key: OFBIZ-12103
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12103
>             Project: OFBiz
>          Issue Type: Bug
>    Affects Versions: 17.12.03
>            Reporter: Rashi Dhagat
>            Assignee: Jacques Le Roux
>            Priority: Major
>         Attachments: CancelItem.webm, OFBIZ-12103.patch, Plugins_OFBIZ-12103.patch
>
>
> Steps to regenerate:
> 1. Open https://demo-stable.ofbiz.apache.org/ecommerce/control/main
> 2. Place an order with multiple items
> 3. Click on order history
> 4. Click on View 
> 5. Select an item
> 6. Choose the reason and click on cancel
> Actual: The order item is not canceled.
> Please refer the attachment.

--
This message was sent by Atlassian Jira
(v8.3.4#803005)