[jira] [Commented] (OFBIZ-12140) Ampersand in Party not displayed correctly

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-12140) Ampersand in Party not displayed correctly

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-12140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270691#comment-17270691 ]

ASF subversion and git services commented on OFBIZ-12140:
---------------------------------------------------------

Commit a5fdd7b063dd446b51311ebbc379b0dba4309a3f in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a5fdd7b0 ]

Fixed: Ampersand in Party not displayed correctly (OFBIZ-12140)

In the reported case, ModelFormField::getDescription double HTML encodes the
description when both the entity and the description contain an ampersand.

A solution is to test if the description is already HTML encoded before encoding
it again. If HTML encoded then only String encodes it.

BTW I'm not sure it's useful but it's harmless, the same solution can be applied
to OFBIZ-12026 and similarly in renderableFtlFormElementsBuilder::encode. I'll
do as improvements...

Thanks: Andrew Waters for report and help in analysis


> Ampersand in Party not displayed correctly
> ------------------------------------------
>
>                 Key: OFBIZ-12140
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12140
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product/catalog
>    Affects Versions: 17.12.04
>         Environment: Linux Ubuntu 20.04.01
>            Reporter: Andrew Waters
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>         Attachments: Image 001.png, Image 001.png, Live-DemoBandQ.png, Screenshot from 2021-01-16 12-41-52.png, Screenshot from 2021-01-20 11-04-48.png, localBandQ.png, mixedAmpersand.png
>
>
> I have a supplier with ID/Name "B&Q" and is incorrectly display when showing the suppliers tab of a product with this supplier.  The Drop-down to select a supplier is fine but the display is "B&Q" for the name (the [ID} is ok). 
> Screenshot attached



--
This message was sent by Atlassian Jira
(v8.3.4#803005)