[
https://issues.apache.org/jira/browse/OFBIZ-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267467#comment-17267467 ]
ASF subversion and git services commented on OFBIZ-12142:
---------------------------------------------------------
Commit e1d57fba007684f1aaec9cdcc358ec526548aec3 in ofbiz-framework's branch refs/heads/release17.12 from Jacques Le Roux
[
https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e1d57fb ]
Fixed: Creating a new Customer create a wrong record in CommunicationEvent (OFBIZ-12142)
In
https://markmail.org/message/pf3d3qyjfucicbj7 I initially answered:
In demo data 13 parties use <<infoString="
[hidden email]">> as in
<ContactMech contactMechId="FRA01" contactMechTypeId="EMAIL_ADDRESS" infoString="
[hidden email]"/>
This one is loaded last. Rather
<ContactMech contactMechId="Company" contactMechTypeId="EMAIL_ADDRESS" infoString="
[hidden email]"/>
which is the 1st one, should be loaded last.
A better solution is to use "
[hidden email]" in EmailServices.xml
Indeed, fortunately the Company party also uses this infoString and using it in
EmailServices.xml does not affect the integration test and should not affect
other parts of the (only) demo data
Thanks: Emad Radwan for opiniated report :) and Pritam Kute for issue analysis
> Creating a new Customer create a wrong record in CommunicationEvent
> -------------------------------------------------------------------
>
> Key: OFBIZ-12142
> URL:
https://issues.apache.org/jira/browse/OFBIZ-12142> Project: OFBiz
> Issue Type: Bug
> Components: framework/common, party
> Affects Versions: Trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Major
>
> Excerpts from this user ML thread: [
https://markmail.org/message/pf3d3qyjfucicbj7]
> Reportedby Emad Radwan <
[hidden email]>:
> {quote}While creating a new Customer a new related record is created in CommunicationEvent table
> {quote}
> Answered by Pritam Kute <
[hidden email]>:
> {quote}In OOTB flow, after creating a customer, the system calls sendCreatePartyEmailNotification service asynchronously. This service is called to send an email notification to the customer about account creation. This causes the creation of a record in CommunicationEvent table.
> I feel that sending email should be configurable but an initial cursory look at the codebase doesn't guarantee about it.
> Also, one thing to notice is that the CommunicationEvent created has a record with partyIdFrom as FrenchCustomer which is completely wrong as it should be a company party. The logic in createCommEventFromEmail (line no. 776) to find out "fromCm" is what causing this problem.
> {quote}
> Answered by myself:
> {quote}
> I think found the reason. In demo data 13 parties use <<infoString="
[hidden email]">> as in
> <ContactMech contactMechId="FRA01" contactMechTypeId="EMAIL_ADDRESS" infoString="
[hidden email]"/>
> I guess this one is loaded last. Rather
> <ContactMech contactMechId="Company" contactMechTypeId="EMAIL_ADDRESS" infoString="
[hidden email]"/>
> which is the 1st one, should be loaded last.
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
