[jira] [Commented] (OFBIZ-12147) Allow Unsafe Event Message

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-12147) Allow Unsafe Event Message

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-12147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269332#comment-17269332 ]

James Yong commented on OFBIZ-12147:
------------------------------------

Hi Michael,

The jgrowl message is delayed slightly to avoid race condition as theĀ UNSAFE_EVENT_MESSAGE may be running some scripts.

Other message type do not need the delay. So will make a change to only delay forĀ UNSAFE_EVENT_MESSAGE.

Agreed on the short notice issue. Will give more time for review in the future.

Thanks,
James

> Allow Unsafe Event Message
> --------------------------
>
>                 Key: OFBIZ-12147
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12147
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: base
>    Affects Versions: Upcoming Branch
>            Reporter: James Yong
>            Assignee: James Yong
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-12147
>
>
> Currently, we can display flash message by setting in request attribute "__EVENT_MESSAGE__".
>  Propose to add another request attribute i.e. "__UNSAFE_EVENT_MESSAGE__" for messages that can contain inline javascript.
> One use case is to allow us to display last login timestamp with browser-specific format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)