[jira] [Commented] (OFBIZ-12169) Handle remaining checkstyle errors

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-12169) Handle remaining checkstyle errors

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280149#comment-17280149 ]

Michael Brohl commented on OFBIZ-12169:
---------------------------------------

My proposal would be to leave worker classes and other classes which reasonably could be extended in custom projetcs as is and only change other classes like inner classes to be final.

We can make them final anytime later if we decide so. Still better as today.

I am currently at it so I would provide a commit with this approach.

Happy to get more opinions also.

> Handle remaining checkstyle errors
> ----------------------------------
>
>                 Key: OFBIZ-12169
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12169
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>    Affects Versions: Trunk
>            Reporter: Michael Brohl
>            Assignee: Michael Brohl
>            Priority: Minor
>
> There are still a ggod amount of checkstyle errors which should be addressed.
> We will work on it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)