[jira] [Commented] (OFBIZ-12169) Handle remaining checkstyle errors

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-12169) Handle remaining checkstyle errors

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284154#comment-17284154 ]

ASF subversion and git services commented on OFBIZ-12169:
---------------------------------------------------------

Commit 89b2dbaec9be221770477a01a1479d965d572451 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=89b2dba ]

Improved: Handle remaining checkstyle errors (OFBIZ-12169)

As I mentioned I copied and adapted the code from
document-upload-protection sanitizer. Focused on the issue at hand I did not
take care much about the style.

Finally (pun intended ;)) I prefer to use a try-with-ressource for fos.

Thanks: Wiebke for proposing another solution at
https://github.com/apache/ofbiz-framework/pull/267/commits/51e82c66989b093392a06cb800fc84a7e413fe45


> Handle remaining checkstyle errors
> ----------------------------------
>
>                 Key: OFBIZ-12169
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12169
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>    Affects Versions: Trunk
>            Reporter: Michael Brohl
>            Assignee: Michael Brohl
>            Priority: Minor
>
> There is still a good amount of checkstyle errors which should be addressed.
> We will work on it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)