[jira] [Commented] (OFBIZ-12169) Handle remaining checkstyle errors

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-12169) Handle remaining checkstyle errors

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338843#comment-17338843 ]

ASF subversion and git services commented on OFBIZ-12169:
---------------------------------------------------------

Commit 45f50c910d64c12a2601164fbc64a4a02ef1d833 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=45f50c9 ]

Improved: Handle remaining checkstyle errors (OFBIZ-12169)

This handles the "'(' should be on the previous line?" rule of MethodParamPad

Actually not completely, because there are still some cases that can't be
handled by changing code, notably when a casting is necessary. I believe there
is an error in checkstyle code. I'll discuss that in dev ML before sending
checkstyle team a report.


> Handle remaining checkstyle errors
> ----------------------------------
>
>                 Key: OFBIZ-12169
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12169
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>    Affects Versions: Trunk
>            Reporter: Michael Brohl
>            Assignee: Michael Brohl
>            Priority: Minor
>
> There is still a good amount of checkstyle errors which should be addressed.
> We will work on it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)