[jira] [Commented] (OFBIZ-12171) Handling the JCenter shutdown

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17289973#comment-17289973 ]

Daniel Watford commented on OFBIZ-12171:
----------------------------------------

Hi [~mbrohl],

There wasn't any difference in how files were checked out in git-bash (Windows) vs docker (Linux).

I also built the R18 PRs in WSL2 and has results matching the docker build.

As a test I was able to run unix2dos on one of the files containing the additional NewlineAtEndOfFileCheck errors and the error was removed. This suggested the problem was related to how checkstyle was determining valid line-endings on different platforms and that I always checkout sources with LF line-endings.

A quick check of trunk's config/checkstyle/checkstyle.xml file and we see that LF line-endings have been specified explicitly in trunk, but the same is missing in the R18 pull request.

Trunk:

{noformat}
    <!-- General file conventions -->
    <module name="NewlineAtEndOfFile">
        <property name="lineSeparator" value="lf" />
    </module>

{noformat}


PR276
{noformat}
    <!-- General file conventions -->
    <module name="NewlineAtEndOfFile"/>
{noformat}

Please could you add the additional lineSeparator property to the NewlineAtEndOfFile module in the PR's config/checkstyle/checkstyle.xml file.

> Handling the JCenter shutdown
> -----------------------------
>
>                 Key: OFBIZ-12171
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12171
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>    Affects Versions: Release Branch 18.12, Trunk, 17.12.05
>            Reporter: Michael Brohl
>            Assignee: Michael Brohl
>            Priority: Major
>              Labels: backport-needed
>             Fix For: 18.12.01, Upcoming Branch, 17.12.06
>
>         Attachments: OFBIZ-12171-1712-README.patch
>
>
> Citing Taher's message at [2]:
> Hello Everyone,
>  
> I received emails and checked resources [1] that seem to confirm JCenter from JFrog is going down and that the last day of operation for the repository is going to be May 1st 2021.
>  
> This is a big deal as many running instances will crash unless updated, so not only do future versions of OFBiz need to adapt, but also existing installations.
>  
> I'm not sure how to best handle this? Especially for production instances out there on older versions of OFBiz. Maybe one solution is to host the existing libraries in some temporary location or try to migrate them to MavenCentral ... Whatever is the solution I think we should make a fast move.
>  
> [1] [https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter]
> [https://www.infoq.com/news/2021/02/jfrog-jcenter-bintray-closure]
> [2] [https://lists.apache.org/thread.html/rf8e883ca8b90d51ad9d6d48c46f8f1fcc1cb82cce802daeeab0b910a%40%3Cdev.ofbiz.apache.org%3E]
>  

--
This message was sent by Atlassian Jira
(v8.3.4#803005)