[jira] [Commented] (OFBIZ-12247) Allow to pass a Google API key for geolocation

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353922#comment-17353922 ]

ASF subversion and git services commented on OFBIZ-12247:
---------------------------------------------------------

Commit 7778b7692db43d34967bdd80c89c6fb104e01966 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7778b76 ]

Improved: Allow to pass a Google API key for geolocation (OFBIZ-12247)

This is related to this question from Daniel at
https://github.com/apache/ofbiz-framework/pull/220

I couldn't figure out how to configure OFBiz with my Google API key so ended up
temporarily patching
themes/common-theme/template/includes/GeoLocation.ftl line 44 with my key.
Line 44 looked similar to:
<script src="https://maps.googleapis.com/maps/api/js?key=secret_google_api_key" type="application/javascript"></script>

Is there a way to configure ofbiz with the API key?

Disclaimer: w/o a not free "Google API key" I was not able to test, will ask
Daniel...

Conflicts handled by hand
  framework/common/config/general.properties

> Allow to pass a Google API key for geolocation
> ----------------------------------------------
>
>                 Key: OFBIZ-12247
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12247
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework/common, themes
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>
> This is related to this question from Daniel at [https://github.com/apache/ofbiz-framework/pull/220]
> {quote}
> I couldn't figure out how to configure OFBiz with my Google API key so ended up temporarily patching themes/common-theme/template/includes/GeoLocation.ftl line 44 with my key. Line 44 looked similar to:<script src="https://maps.googleapis.com/maps/api/js?key=_secret_google_api_key_" type="application/javascript"></script>
>  Is there a way to configure ofbiz with the API key?
> {quote}

--
This message was sent by Atlassian Jira
(v8.3.4#803005)