[jira] [Commented] (OFBIZ-1319) Split javascript files to have more generic ones includable in all screens, and the more specific ones included more locally

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-1319) Split javascript files to have more generic ones includable in all screens, and the more specific ones included more locally

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360150#comment-15360150 ]

Jacques Le Roux commented on OFBIZ-1319:
----------------------------------------

I agree, but we could maybe take the opportunity to better split selectall.js into smaller files by related topics
eg from  
function toggle(e) {
to
function highlightAllRows(e, halfRowId, formName){
then popup ones
then Ajax ones
then autocompleter (setLookDescription  is part of it)
I guess you see the plan, I can help more...

We would then push in util.js all the remaining isolated utility functions.

> Split javascript files to have more generic ones includable in all screens, and the more specific ones included more locally
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1319
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1319
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Assignee: Jacques Le Roux
>            Priority: Minor
>
> From a David's E. Jones comment on ML :
> We should split up javascript files to have the more generic ones includable in all screens, and the more specific ones (like the toggle* and selectAll* methods in there) into a file that can be included more locally.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)