[
https://issues.apache.org/jira/browse/OFBIZ-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14176270#comment-14176270 ]
Jacques Le Roux commented on OFBIZ-1524:
----------------------------------------
Is this a bug or an improvement? If it's a bug can't we backport to releases? Else please change the type.
> Improve the way CreditCard.cardType field is managed
> ----------------------------------------------------
>
> Key: OFBIZ-1524
> URL:
https://issues.apache.org/jira/browse/OFBIZ-1524> Project: OFBiz
> Issue Type: Bug
> Components: accounting, order, specialpurpose/ecommerce
> Reporter: Jacopo Cappellato
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-1524.patch
>
>
> The credit card types are hardcoded in the following template (and in a few other ftl files):
>
http://svn.apache.org/repos/asf/ofbiz/trunk/framework/common/webcommon/includes/cctypes.ftl> instead getting the values from the Enumeration entity (we already have value for credit card types, with enumTypeId="CREDIT_CARD_TYPE")
> Also, in the CreditCard.cardType field, instead of storing the Enumeration.enumId field (e.g. CCT_VISA) we store the Enumeration.enumCode field (e.g. "Visa")
> This value is also used in some of the UtilValidate methods; it would be much better to use everywhere the values in the enumId entity.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Locked
