[jira] Commented: (OFBIZ-241) CSS Layout and Other Cleanups in the Manager Applications

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518751 ]

Adrian Crum commented on OFBIZ-241:
-----------------------------------

Mike,

default-selected-style="selected" only works with the newer CSS styles, so you'll also need to specify the correct menu container style, like  this:

menu-container-style="button-bar tab-bar"

Check out the menus in PartyMenus.xml, MarketingMenus.xml, and product/widget/facility/Menus.xml.

Also, take a few minutes to understand the new styles in maincss.css. The concept is to start with a basic horizontal menu style (button-bar) and decorate it with a particular look (button-style-1, button-style-2, tab-bar).

Some of the tasks in this issue are simple search-and-replace operations. Menu widgets is not one of them. You'll have to take a little time to evaluate how the original menu operates, select the correct new style to replace it, and then test the change to make sure it still operates the same.

I can't commit your patches in their current form.

> CSS Layout and Other Cleanups in the Manager Applications
> ---------------------------------------------------------
>
>                 Key: OFBIZ-241
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-241
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting, content, humanres, manufacturing, marketing, order, party, product, workeffort
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>         Attachments: content.menu-widget.patch, order.menu-widget.patch, product.menu-widget.patch, style-info.txt, workeffort.inputBox.patch
>
>
> Copy of http://jira.undersunconsulting.com/browse/OFBIZ-202 from David Jones
> =======================================================
> The purpose of this task is to improve the current CSS based layout, and separate it from the ecommerce application so they do not interfere with eachother. There are some issues with the layout, and lots of room for improvement including in some cases chaging table-based layouts to CSS based, and making styles and HTML structure cleaner and more flexible. This is not meant to be nearly as aggessive an effort as in ecommerce, and is meant more for general improvements and not to facilitate extremely flexible customization and such as is the case in ecommerce.
> I would like to propose the removal of all redundant style info... for example, nearly all <div class="tabletext"> wrappers can be removed, the exception being where they are used like <p>s - the default text style can be set on body; all "inputBox", "selectBox", "smallSubmit" styles can be removed - can style input elements globally; remove embedded style="margin: 0" on forms, style forms globally; change <div class="head1|head2|head3"> to <h1|h2|h3>, etc. (Just the ones off the top of my head, I'm sure there are more.)
> I would be happy to help with this, but due to the large number of files affected, it will probably need to be coordinated with any other css work.
> I agree with this approach Joe. It is much more flexible and will reduce the HTML size a fair bit, and with proper labelling of different areas it can be very flexible too. This is what I've done with the ofbiz.org home page.
> You're right about this requiring a lot of changes in lots of different files. I'm not sure what the best way to manage this is, but to get it started it is probably best to choose 2-3 "proof of concept" pages and get those cleaned up, and then solicit help with others based on those.
> Of course, chances are no one except the core group will help anyway, but I always find it entertaining to try...
> I would be willing to help as well, if you like. I have converted my ecommerce site already to css (www.heatwithsolar.com). Since my goal is to use OFBiz on my site, I have a strong desire to retain CSS level 1 capability. I have no real need to go to a higher standard of CSS yet until it is supported by more browsers.
> As soon as I get an SVN up and running well, I'll likely start working on this anyways. Just let me know. [hidden email]

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.