[
https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221702#comment-13221702 ]
Jacques Le Roux commented on OFBIZ-2628:
----------------------------------------
Hi Sascha,
It works here. But I read in the autocompletion JavaDoc (using 1.6.22 in Eclipse on Windows XP)
{quote}
Note: The World Wide Web Consortium Recommendation states that UTF-8 should be used. Not doing so may introduce incompatibilites.
{quote}
This is best explained here
http://www.w3.org/TR/html40/appendix/notes.html#non-ascii-charsThough I did not find a so affirmative advice in the [Java 6 API doc|
http://docs.oracle.com/javase/6/docs/api/java/net/URLEncoder.html], I also read
{quote}
The recommended encoding scheme to use is UTF-8. However, for compatibility reasons, if an encoding is not specified, then the default encoding of the platform is used.
{quote}
So I think we should rather use Charset.forName("UTF-8").displayName() instead of Charset.defaultCharset().displayName(). AFAIK, UTF-8 should fits with all server and clients types...
> No Url encoding for get parameters
> ----------------------------------
>
> Key: OFBIZ-2628
> URL:
https://issues.apache.org/jira/browse/OFBIZ-2628> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk
> Environment: All
> Reporter: Patrick Antivackis
> Assignee: Sascha Rodekamp
> Priority: Critical
> Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Let's say I want to create a new category which ID is DVD+R
> Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId=.... of the url is wrong as it's not url encoded, so we have :
>
https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD+R instead of
>
https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR> Both <@ofbizUrl> tag and menu widgets are not encoding get parameters.
> Way to correct :
> framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function
> framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder
> Beofre i do the fix, can a core developper let me know about possible side effects
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspaFor more information on JIRA, see:
http://www.atlassian.com/software/jira
Locked
