[
https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463761#comment-13463761 ]
Wojciech Szymanowski commented on OFBIZ-2628:
---------------------------------------------
Hello,
I am using 11.04 version, and have noticed that CatalinaContainer.createConnector() method does not initialize Connector.URIEncoding property from ContainerConfig class.
Current code in CatalinaContainer.createConnector() which does not work for URIEncoding property:
for (ContainerConfig.Container.Property prop: connectorProp.properties.values()) {
connector.setProperty(prop.name, prop.value);
}
When I added following lines:
if (connectorProp.properties.containsKey("URIEncoding")) {
connector.setURIEncoding(connectorProp.properties.get("URIEncoding").value);
}
... it solved the problem.
> No Url encoding for get parameters
> ----------------------------------
>
> Key: OFBIZ-2628
> URL:
https://issues.apache.org/jira/browse/OFBIZ-2628> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk
> Environment: All
> Reporter: Patrick Antivackis
> Assignee: Sascha Rodekamp
> Priority: Critical
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Let's say I want to create a new category which ID is DVD+R
> Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId=.... of the url is wrong as it's not url encoded, so we have :
>
https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD+R instead of
>
https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR> Both <@ofbizUrl> tag and menu widgets are not encoding get parameters.
> Way to correct :
> framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function
> framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder
> Beofre i do the fix, can a core developper let me know about possible side effects
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Locked
