[jira] [Commented] (OFBIZ-2628) No Url encoding for get parameters

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-2628) No Url encoding for get parameters

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465409#comment-13465409 ]

Jacques Le Roux commented on OFBIZ-2628:
----------------------------------------

Hi Sascha,

DId you try with a white space in name as Deepak suggested? I reproduce locally with "Test Attr"
{code}
2012-09-28 08:19:35,000 (http-bio-0.0.0.0-8443-exec-3) [    TransactionUtil.java:379:WARN ]
---- exception report ----------------------------------------------------------
[TransactionUtil.setRollbackOnly] Calling transaction setRollbackOnly; this stack trace shows where this is happening:
Exception: java.lang.Exception
Message: Error in simple-method [delete a ProductAttribute [file:/D:/workspace/ofbizClean/applications/product/script/org/ofbiz/product/product/ProductServices.xml#deleteProductAttribute]]: Error running the
simple-method: Entity value not found with name: lookedUpValue Method = deleteProductAttribute, File = file:/D:/workspace/ofbizClean/applications/product/script/org/ofbiz/product/product/ProductServices.xml,
Element = <remove-value>, Line 961null
---- stack trace ---------------------------------------------------------------
{code}

Looking at lookedUpValue Method = deleteProductAttribute...
               

> No Url encoding for get parameters
> ----------------------------------
>
>                 Key: OFBIZ-2628
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2628
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk
>         Environment: All
>            Reporter: Patrick Antivackis
>            Assignee: Sascha Rodekamp
>            Priority: Critical
>             Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>         Attachments: OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-Add-URL-encoding-to-RequestHandler.patch, OFBIZ-2628-encoding-hidden-post-params (list forms).patch, OFBIZ-2628-encoding-hidden-post-params.patch, OFBIZ-2628-encoding-request-redirect-params.patch
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Let's say I want to create a new category which ID is  DVD+R
> Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId=.... of the url is wrong as it's not url encoded, so we have :
> https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD&#43;R instead of
> https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR
> Both <@ofbizUrl> tag and menu widgets are not encoding get parameters.
> Way to correct :
> framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function
> framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder
> Beofre i do the fix, can a core developper let me know about possible side effects

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira