[jira] Commented: (OFBIZ-269) Ajax a form element in ofbiz

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464255 ]

Si Chen commented on OFBIZ-269:
-------------------------------

Jacques,

I think the patch is a good demonstration of how it could be done but would need quite a bit of work before it should be committed.  I'd prefer something where the returned result from the search is not formatted inside a java method but by a FTL which can be modified more easily.  Also it might be better to use one of Andy's ajax libraries instead of the custom ajax javascript here.  

Andy put some ajax stuff into the framework and wanted a general standard pattern, and I think that's what we should try to do.

Si

> Ajax a form element in ofbiz
> ----------------------------
>
>                 Key: OFBIZ-269
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-269
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>         Environment: Based on svn 7564
>            Reporter: Marco Risaliti
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>         Attachments: ajax.js, AjaxPartyEvents.java, AjaxPartyEvents_2.java, AjaxPartyServices.java, AjaxPartyServices_2.java, diff.log, diff_2.log
>
>
> This is a copy of the old Jira issue http://jira.undersunconsulting.com/browse/OFBIZ-885 from Fred Forester.
> ======================================================
> This is an exmaple of how to Ajaxize a control in ofbiz. It uses an auto complete event
> for the last name on the party lookup page. when the last name is selected it fills the partyId on the form. the example does not take any role types or groups into account.
>  
>  
>  All    Comments    Work Log    Change History       Sort Order:  
> Comment by Fred Forester [16/May/06 10:14 AM] [ Permlink ]
> patch file
> Comment by Fred Forester [16/May/06 10:15 AM] [ Permlink ]
> new file
> Comment by Fred Forester [16/May/06 10:17 AM] [ Permlink ]
> a patch and a new file
> Comment by Fred Forester [16/May/06 10:19 AM] [ Permlink ]
> Sorry about the duplicate files. the upload made it appear to me that one replaced the other. :)
> Comment by Si Chen [19/May/06 09:14 AM] [ Permlink ]
> This is my version of your AjaxPartyServices.java as AjaxPartyEvents.java
> Comment by Si Chen [19/May/06 09:16 AM] [ Permlink ]
> Hey everybody - this works!
> I looked at your code and would like to suggest -
> 1. AjaxPartyServices.java is really AjaxPartyEvents.java since you have written an Events servlet not a Service. I just changed it and uploaded it for you.
> 2. I think a lot of the Javascript in findparty.ftl should be moved into an ajax javascript file that could be shared everywhere, since they seem to be pretty standard?
> 3. Please clean up the formatting of AjaxPartyEvents.java. See http://ofbizwiki.go-integral.com/Wiki.jsp?page=FAQ27 
> Comment by Si Chen [19/May/06 09:38 AM] [ Permlink ]
> David and Andy -
> Can you make a specialized/ajax directory so we can put some ajax-related stuff in there, like this, that all the applications/ can use, but at the same time not mess with framework/?
> Comment by Fred Forester [19/May/06 09:42 AM] [ Permlink ]
> I agree 100% with all 3 points and had every intention of getting to 1 and 2. didn't know about 3 till just now :(
> I found out last night after loading 200,000 users that things got a little slow.
> a temporary fix was to require at least 5 characters in the lastname.
> I'm working on 2 other jira things now and can get to this on tuesday.
>  
> Comment by Si Chen [19/May/06 11:21 AM] [ Permlink ]
> Great.
> Also I think it would be nice to change your AjaxPartyEvents.java to a more generic AjaxEvents.java and parametrize the entities and fields, etc., so that it could be used everywhere for auto-completion. We could then integrate it into the form-widget at a later date.
> Comment by Fred Forester [23/May/06 04:51 PM] [ Permlink ]
> Here are the new files for the ajax lastname control. I wasnt sure what was wrong with the formatting. maybe a critique of the formatting would give me a better idea of what's wrong.
> Fred

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira