[jira] Commented: (OFBIZ-270) USPS Rate Estimation

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466929 ]

Daniel Kunkel commented on OFBIZ-270:
-------------------------------------

Hi

Found a couple more little things. Here's the patch:

Index: UspsServices.java
===================================================================
--- UspsServices.java   (revision 498687)
+++ UspsServices.java   (working copy)
@@ -16,6 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.

*******************************************************************************/
+
 package org.ofbiz.shipment.thirdparty.usps;

 import java.io.ByteArrayOutputStream;
@@ -158,8 +159,8 @@
             packageElement.setAttribute("ID", String.valueOf
(li.nextIndex() - 1)); // use zero-based index (see examples)

             UtilXml.addChildElementValue(packageElement, "Service",
serviceCode, requestDocument);
-            UtilXml.addChildElementValue(packageElement,
"ZipOrigination", originationZip, requestDocument);
-            UtilXml.addChildElementValue(packageElement,
"ZipDestination", destinationZip, requestDocument);
+            UtilXml.addChildElementValue(packageElement,
"ZipOrigination", originationZip.substring(0,5), requestDocument);
+            UtilXml.addChildElementValue(packageElement,
"ZipDestination", destinationZip.substring(0,5), requestDocument);

             double weightPounds = Math.floor(packageWeight);
             double weightOunces = Math.ceil(packageWeight * 16 % 16);
@@ -293,7 +294,7 @@
                 }

                 if (result.get(ModelService.RESPONSE_MESSAGE).equals
(ModelService.RESPOND_SUCCESS)) {
-                    productWeight *= ((Double) result.get
("convertedValue")).doubleValue();
+                    productWeight = ((Double) result.get
("convertedValue")).doubleValue();
                 } else {
                     Debug.logError("Unsupported weightUom [" +
weightUomId + "] for calcPackageWeight running productId " + productId +
", could not find a conversion factor to WT_lb",module);
                 }
@@ -1349,7 +1350,6 @@

> USPS Rate Estimation
> --------------------
>
>                 Key: OFBIZ-270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-270
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Any
>            Reporter: Marco Risaliti
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: shipping.patch
>
>
> This is a copy of the old Jira issue http://jira.undersunconsulting.com/browse/OFBIZ-657 from Daniel Kunkel
> ===========================================================
> The USPS automatic Rate Inquiry module has numerous flaws.
> I was able to find and fix them, albeit, with potentially unacceptable techniques.
> Specifically:
> 1.) USPS now uses Get and does not Post any longer.
> 2.) Pounds must be a integer number.
> 3.) The calculation for breaking a weight into pounds and ounces was inaccurate. (UPS module too)
> 4.) The HttpClient HTTP GET was inserting & between the value pairs instead of &
> !!!! My fix for this issue may not be appropriate!
> 5.) No provision for converting other units of measure to Pounds. Other parts of the program seem to default to the ounce, while shipping defaulted to the pound.
> Remaining Issues...
> Must find a way to disable the estimator during an error. The system currently defaults to $1, which is a believeable, yet money loosing postage.
> Need to add International Shipping Support.
> Finally... This is my first patch contribution... It will need extra time and attention to verify!
> Thanks
> Daniel
>  
>  
>  All    Comments    Work Log    Change History       Sort Order:  
> Comment by Daniel Kunkel [08/Jan/06 02:13 AM] [ Permlink ]
> My fixes which SEEM to work. Your milage may vary.
> Comment by Marco Risaliti [13/Sep/06 01:43 AM] [ Permlink ]
> Can be closed ?
> Thanks
> Marco
> Comment by Daniel Kunkel [13/Sep/06 02:09 AM] [ Permlink ]
> I think it would be a waste to close this issue without first applying the patch... Granted it was my first patch and even I don't like the code, but it did get the domestic USPS postal calculator working which has been a real boon for our business. Furthermore it allowed for the conversion of product weights to lbs for the usps, another feature we needed.
> PS. I do have an iCLA signed.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.