[jira] Commented: (OFBIZ-309) If a service is implemented as an interface, its settings for optional attributes are ignored!

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-309) If a service is implemented as an interface, its settings for optional attributes are ignored!

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473314 ]

Scott Gray commented on OFBIZ-309:
----------------------------------

Hi Leon, Si

I can't see any thing in the svn histories that wouldn have caused this to "break", so that and the commit mentioned above makes me wonder if the behaviour is intentional.  I'd be interested in hearing David or Andy's comments (their commits are the only ones of any substance on the affected files) on this before anything was changed.


> If a service is implemented as an interface, its settings for optional attributes are ignored!
> ----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-309
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-309
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon Torres
>         Assigned To: Si Chen
>            Priority: Critical
>         Attachments: services.patch
>
>
> This is bad:
> If a service has some attributes with optional="false" and is implemented with <implements service="">, the settings for optional are ignored and default to "true" instead.
> As an example, look up the service definition for  upsRateEstimate  in webtools and compare to the service that it implements, calcShipmentEstimateInterface.  The interface defines a few optional fields as false, which show up correctly for calcShipmentEstimateInterface but are all set to true in upsRateEstimate.
> It used to work, something must have broken it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.