[jira] [Commented] (OFBIZ-3155) Enhancing the useability of SFA by including an overview of the agreements of the account into the Account Screen

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-3155) Enhancing the useability of SFA by including an overview of the agreements of the account into the Account Screen

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255002#comment-13255002 ]

Erwan de FERRIERES commented on OFBIZ-3155:
-------------------------------------------

Pierre,

I reviewed your patch. You should look to the contributor's best practices, and configure your IDE (tabs to spaces).
css modification is not needed, as already existing.
And for the modification for agreementScreens.xml#EditAgreement (setting values) I don't agree with it, you shouldn't set company directly in the code.
               

> Enhancing the useability of SFA by including an overview of the agreements of the account into the Account Screen
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-3155
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3155
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: marketing
>            Reporter: Pierre Smits
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3155 sfa-accounts-agreements.patch, sfa-accounts-agreements.patch
>
>
> This improvement includes:
> Adding an overview of associated agreements with the account to the account screen
> Adding the functionality to create agreements from the account screen, with setting the default agreement parties (Company and the account)
> The modifications are realized on:
> \applications\accounting\widgets\agreementscreen.xml - setting default agreement parties
> \applications\party\webapp\partymgr\static\partymgr.css - including of style elements for overviews in the bottom position of account screen
> \applications\party\widget\partymgr\profilescreens.xml  - including a screen for partyAgreements
> \applications\party\widget\partymgr\partyforms.xml - including a form to render the overview of agreements for accounts
> \applications\marketing\widget\sfa\sfamenus.xml - including the menu to create new agreements from the acount screen
> \applications\marketing\widget\sfa\commonscreen.xml - including functionality to add the overview of agreements to the bottom of the account screen.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira