[jira] [Commented] (OFBIZ-3342) A Few Service names dont follow normal camel case rules?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-3342) A Few Service names dont follow normal camel case rules?

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-3342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449134#comment-15449134 ]

Swapnil M Mane commented on OFBIZ-3342:
---------------------------------------

I was using service reference from webtools and found below-given services not following this practice (lowerCamelCase pattern for naming a service) which should be corrected

# AddProductToBestSellCategory
# EbayStoreCreateOrderShoppingCart
# EbayStoreCreateTransactionShoppingCart
# EbayStoreImportOrder
# EbayStoreImportTransaction
# FindBestSellingProduct
# FindCategoryChild
# MoveItemBetweenShipGroups
# RemoveProductFromBestSellCategory
# SagePayPaymentAuthentication
# SagePayPaymentAuthorisation
# SagePayPaymentRefund
# SagePayPaymentRelease
# SagePayPaymentVoid

Along with updating name of this service, we should change the existing references of these services.

> A Few Service names dont follow normal camel case rules?
> --------------------------------------------------------
>
>                 Key: OFBIZ-3342
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3342
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Sam Hamilton
>            Assignee: Swapnil M Mane
>            Priority: Trivial
>
> I know this is not really a bug and perhaps its just me being very picky, so please let me know if this is wrong but in this list of services there are a few which dont follow camel case
> https://demo.ofbiz.org/webtools/control/ServiceList
> e.g.
> ConvertOfbizCartToGoogle
> FindProducts
> anyway they are all at the top of the list if you think I am right.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)