[jira] [Commented] (OFBIZ-3774) Add The Visitor Pattern To Screen Widget Model Classes

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164449#comment-13164449 ]

Dimitri Unruh commented on OFBIZ-3774:
--------------------------------------

The main reason is a better overview :) A ModeScreenWidget.java with 2000 lines isn't easy to maintain.

At the end I would prefer something like:
{code}
org.ofbiz.widget.screen.action
org.ofbiz.widget.screen.condition
org.ofbiz.widget.screen.handler
org.ofbiz.widget.screen.renderer
org.ofbiz.widget.screen.widget
{code}

I also would do this for form, menu and tree. So it would be more clear if you are searching for something.

               

> Add The Visitor Pattern To Screen Widget Model Classes
> ------------------------------------------------------
>
>                 Key: OFBIZ-3774
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3774
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774.patch, OFBIZ-3774_ScreenWidgetVisitor.patch, OFBIZ-3774_ScreenWidgetVisitor.patch
>
>
> From time to time there has been interest expressed in introducing the visitor pattern to the screen widget model classes. This issue is intended to provide a forum on the subject and a means to vote on it. Details are in the comments.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira