[
https://issues.apache.org/jira/browse/OFBIZ-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720521#comment-16720521 ]
Jacques Le Roux commented on OFBIZ-3844:
----------------------------------------
So, like someone in the past who upsetted Adrian with a better English knowledge than him ;), you are saying that Adrian's approach does not fit? I see no problem renaming as initially proposed. Anyway I forgot to put the description in label file as Adrian suggested. Though I'll use an xml comment rather than a <description> element which is not in ofbiz-properties.xsd and we already do that elsewhere.
> Splitting CommonRate and CommonProductRating
> --------------------------------------------
>
> Key: OFBIZ-3844
> URL:
https://issues.apache.org/jira/browse/OFBIZ-3844> Project: OFBiz
> Issue Type: Improvement
> Components: framework, product
> Affects Versions: Release 09.04
> Environment: irrelevant, only XML and FTL changes
> Reporter: Carsten Schinzer
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 0001-OFBIZ-3844_commonRate_and_commonRating.patch, 0002-OFBIZ-3844_commonRate_and_commonRating.patch, OFBIZ-3844_Splitting CommonRate and CommonProductRating_part1.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The CommonRate label is currently not used coherently throughout the application stack. The existing translations suggest that the commonly understood meaning of CommonRate is a rate as a tariff or day rate. However, in the product management GUI, the CommonRate label is used to demark the section where ProductRating setting are made.
> The provided fix splits CommonRate into two labels, CommonRate and CommonProductRating. Also, the application/product/webapp/ form definition now references the CommonProductRating label.
> Unfortunately, the patches have to be provided per affected file, i.e. two patches make this imporvement.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
