[jira] Commented: (OFBIZ-400) Allow ShoppingCartHelper.addToCart to be called from simple-method

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-400) Allow ShoppingCartHelper.addToCart to be called from simple-method

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466644 ]

David E. Jones commented on OFBIZ-400:
--------------------------------------

Chris: thanks for looking more into this. I looked at you patch and decided a variation on it might be a little easier to use.

I'm guessing that the .class and .TYPE entries were based on the 2 code references you listed, though those are written differently and have object Maps instead of a String-Object Map like we use in the OFBiz cached class loader.

With this we should be able to use just "int" or "boolean" for these types.

I guess this doesn't close the issue yet... but will hopefully make it possible to call that method without adding a custom one.

Anyway, let me know if you need any other patches in related to this, or if not I'll just close it.

Thanks Chris!

> Allow ShoppingCartHelper.addToCart to be called from simple-method
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-400
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-400
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Chris Howe
>         Assigned To: David E. Jones
>            Priority: Minor
>         Attachments: CachedClassLoader.patch, CachedClassLoader.patch, ShoppingCartHelper.patch
>
>
> To my knowledge a primitive type double cannot be sent from <call-object-method> in minilang.  So to allow ShoppingCartHelper.addToCart to be usable from minilang there are three possible solutions.
> 1)Change minilang to pass primitive type double (if there is a way to do this already, disregard this issue)
> 2)Change addToCart to accept Double quantity instead of double quantity
> 3)Create additional method that accepts Double quantity and then passes that to the current addToCart with a quantity.doubleValue()

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.