[
https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689503#comment-16689503 ]
Jacques Le Roux commented on OFBIZ-4160:
----------------------------------------
Hi Benjamin,
Your patch looks good to me. Before I commit: I did not test, but I guess you did?
Also I'd
* remove this comment:
{code}
// FIXME handles shipping and promo tax. Simple solution, see
//
https://issues.apache.org/jira/browse/OFBIZ-4160 for a better one
{code}
* would remove AccountingTaxAuthorityCategoryAdvice
* would close as won't fix OFBIZ-5662
I let you (or Pierre) create a new Jira for the discussion you had wich makes sense to me, thanks.
> Tax not added for order shipping or promotion
> ---------------------------------------------
>
> Key: OFBIZ-4160
> URL:
https://issues.apache.org/jira/browse/OFBIZ-4160> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk
> Environment: rev 1065908
> Reporter: Paul Foxworthy
> Assignee: Jacques Le Roux
> Priority: Major
> Labels: VAT, tax
> Attachments: OFBIZ-4160_shipping_tax.patch, OFBIZ-4160_weighted_shipping_tax.patch
>
>
> When shipping is calculated for the entire order or a promotion adjustment is made, the relevant tax rows from the TaxAuthorityRateProduct table are not being found.
> Here's a patch.
> This bug was discovered independently by Sergei Biletnikov, see
http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Locked
