[jira] Commented: (OFBIZ-456) Invoice item sequence ids are ordered alphabetically, not numerically

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490635 ]

Chris Howe commented on OFBIZ-456:
----------------------------------

Hi Jacopo,

To be consistant, the padding for this should be 5, not 4.

InvoiceServices.java uses the service createInvoiceItem, which sets the invoiceItemSeqId using simple-method operation <make-next-seq-id> if invoiceItemSeqId DNE.  Simple-method operation defaults the padding to  5 if it is not provided in the numeric-padding attribute which is the case here.
http://svn.apache.org/viewvc/ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/entityops/MakeNextSeqId.java?view=markup

> Invoice item sequence ids are ordered alphabetically, not numerically
> ---------------------------------------------------------------------
>
>                 Key: OFBIZ-456
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-456
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Iain Fogg
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>
> Invoice item sequence numbers start with 2 significant "digits" (01, 02, etc). Not a problem until you have an invoice with more than 99 items, and then you find item 100 being displayed after item 10.
> I expect the desired behaviour (and improvement) is obvious :-)

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.