[jira] Commented: (OFBIZ-46) Product -> Inventory Screen Improvement for Virtual Products

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-46) Product -> Inventory Screen Improvement for Virtual Products

Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-46?page=comments#action_12417594 ]

Jacopo Cappellato commented on OFBIZ-46:
----------------------------------------

Scott,

thanks for your work.
Your patch is good and I've committed it with some minor mods in revision 7856.

Here are my comments (and suggestions for future patches):

1) please don't mix formatting cleanups and funcional changes in the same patches: always create speparate patches for formatting changes; in this way it is much more simple to review the relevant changes;

2) please try to create patches with relative paths instead of absolute ones; for example

BAD:
Index: //Server/C/ofBiz/applications/product/config/ProductUiLabels.properties

GOOD:
Index: applications/product/config/ProductUiLabels.properties

3) in bsh files, when called by screens, there the "dispatcher" and "delegator" objects are always available; there is no need to insert statements like the following one:

dispatcher = request.getAttribute("dispatcher");

That's all; I look forward at getting more patches from you.
Thanks,
Jacopo

> Product -> Inventory Screen Improvement for Virtual Products
> ------------------------------------------------------------
>
>          Key: OFBIZ-46
>          URL: http://issues.apache.org/jira/browse/OFBIZ-46
>      Project: The Open For Business Project
>         Type: Improvement

>   Components: product
>     Versions: SVN trunk
>     Reporter: Scott Gray
>     Assignee: Jacopo Cappellato
>     Priority: Minor
>  Attachments: VirtualInvSummary.patch
>
> Hi
> I've changed the EditProductInventoryItems screen in ProductScreens.xml to display a summary of  variant products inventory when a virtual product is being browsed.  
> Currently the screen displays the standard inventory info for the variant which isn't very useful as the product doesn't actually exist in a physical sense.
> The summary information displayed is pretty basic but I wanted to be careful because of the number of variants that could potentially be displayed.  I figure the information on screen can be expanded as people see the need and also perhaps add facility/feature filters where appropriate to drill deeper.
> Coding feedback is most welcome as I'm still climbing a pretty steep hill in terms of learning ofbiz / java / ftl / bsh / widgets etc.
> Thanks
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira