[
https://issues.apache.org/jira/browse/OFBIZ-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520868 ]
David E. Jones commented on OFBIZ-495:
--------------------------------------
Adrian,
I started reviewing this with the intent of committing it, but some of the issues I mentioned before still exist, and what is implemented here varies too much from best practices to be a good basis for what will likely live for a long time and be expanded and such quite a bit.
1. 4 spaces, no tabs; also always 4 spaces and not 6, not 2
2. don't create new files where not necessary, and where it varies from establish artifacts and practices, specifically the UserPrefMessages.properties, UserSecurityData.xml, and UserServicesData.xml
3. name things using names that get to the point; for example, services_user.xml is not only not specific, it is misleading; the point of that file is preferences not users
4. implement these data moving services using simple-methods rather than Java; based on a quick review the code will be about 1/4 the size
5. if you are going to implement in Java, at least follow the Sun standard code formatting guidelines that we are trying to get everyone to use, as mentioned here:
http://docs.ofbiz.org/display/OFBADMIN/Coding+ConventionsAfter more experience with OFBiz I think you're probably aware of much of this, and I know that most of this is older code. One way or another this stuff needs to be cleaned up. Don't take it too personally, this sort of new addition is actually one of the easier types of things to review thoroughly.
> User Preferences Feature
> ------------------------
>
> Key: OFBIZ-495
> URL:
https://issues.apache.org/jira/browse/OFBIZ-495> Project: OFBiz
> Issue Type: New Feature
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: COLLAPSD.JPG, example.patch, EXPANDED.JPG, user_pref.patch, user_pref.patch
>
>
> The User Preferences Services are intended to store and retrieve the current user's preferences. User preferences can be used to control UI elements, frequently used search and report criteria, and more.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Locked
